Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vitest in create-cloudflare templates #5863

Closed

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented May 18, 2024

What this PR solves / how to test

This simply updates the create-cloudflare templates to use a newer vitest version, as a followup to #5458 now that's been released.

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@Cherry Cherry requested review from a team as code owners May 18, 2024 23:49
Copy link

changeset-bot bot commented May 18, 2024

⚠️ No Changeset found

Latest commit: 9eb7869

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-wrangler-5863

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5863/npm-package-wrangler-5863

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-wrangler-5863 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-create-cloudflare-5863 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-kv-asset-handler-5863
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-miniflare-5863
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-pages-shared-5863
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9143438724/npm-package-cloudflare-vitest-pool-workers-5863

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.57.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

I'll run the e2e tests before merging...

@Cherry
Copy link
Contributor Author

Cherry commented May 19, 2024

Thanks. There are some other type errors here that I'm not really sure why are happening honestly. I'll see if I can get a chance to look over them at some point this week.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unapproving while we work out the failures

@threepointone
Copy link
Contributor

Didn't notice this open PR, I picked it up in #6076. I did only mark vitest to 1.5.0, I'll mark it up in 1.5.3 in the next release. Thank you very much for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants